On Mon, Apr 20, 2015 at 5:34 PM, Sonny Rao <sonnyrao@xxxxxxxxxxxx> wrote: > This uncore is the same as the Haswell desktop part but uses a > different PCI ID. > > Signed-off-by: Sonny Rao <sonnyrao@xxxxxxxxxxxx> You don't need my ack, and I don't know enough to review the perf stuff anyway, but the way you handled the PCI device ID looks great to me. > --- > arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c > index 3001015..ca75e70 100644 > --- a/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c > +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore_snb.c > @@ -1,6 +1,9 @@ > /* Nehalem/SandBridge/Haswell uncore support */ > #include "perf_event_intel_uncore.h" > > +/* Uncore IMC PCI Id */ > +#define PCI_DEVICE_ID_INTEL_HSW_U_IMC 0x0a04 > + > /* SNB event control */ > #define SNB_UNC_CTL_EV_SEL_MASK 0x000000ff > #define SNB_UNC_CTL_UMASK_MASK 0x0000ff00 > @@ -472,6 +475,10 @@ static const struct pci_device_id hsw_uncore_pci_ids[] = { > PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HSW_IMC), > .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), > }, > + { /* IMC */ > + PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HSW_U_IMC), > + .driver_data = UNCORE_PCI_DEV_DATA(SNB_PCI_UNCORE_IMC, 0), > + }, > { /* end: all zeroes */ }, > }; > > @@ -502,6 +509,7 @@ static const struct imc_uncore_pci_dev desktop_imc_pci_ids[] = { > IMC_DEV(IVB_IMC, &ivb_uncore_pci_driver), /* 3rd Gen Core processor */ > IMC_DEV(IVB_E3_IMC, &ivb_uncore_pci_driver), /* Xeon E3-1200 v2/3rd Gen Core processor */ > IMC_DEV(HSW_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core Processor */ > + IMC_DEV(HSW_U_IMC, &hsw_uncore_pci_driver), /* 4th Gen Core ULT Mobile Processor */ > { /* end marker */ } > }; > > -- > 2.1.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html