On Wed, Apr 8, 2015 at 8:17 PM, Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 2015-04-08 at 17:06 -0700, Yinghai Lu wrote: > I'll let Bjorn be the final judge here but I am not fan of the way you > set/clear/set/clear the IORESOURCE_PREFETCH bit with > pci_set_pref_under_pref(). It's error prone and confusing, the code is > already barely readable as it is ... We only use them to wrapping final pci_claim*, sizing, and assigning. that is limited places. > > I would rather you replace those various masks compares with a helper > that does something like pci_resource_compatible(parent_res, child_res), > which has the logic to test. That or a helper that does something like > pci_calc_compatible_res_flags() which returns a "flags" that has > PREFETCH set, which you use in place of res->flags in the various > allocation path. That way should be more intrusive to current code, as we are using type_mask checking to share the code among parent(pref)/child(pref), parent(no-pref)/child(pref), and parent(no-pref)/child(pref) Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html