Now one should be using pci_msi_off now, unexport it and move the declaration to internal header to prevent misuse. Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> --- drivers/pci/pci.h | 2 ++ include/linux/pci.h | 1 - drivers/pci/pci.c | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/pci/pci.h b/drivers/pci/pci.h index 17f213d..620fcad 100644 --- a/drivers/pci/pci.h +++ b/drivers/pci/pci.h @@ -146,6 +146,8 @@ static inline void pci_no_msi(void) { } static inline void pci_msi_init_pci_dev(struct pci_dev *dev) { } #endif +void pci_msi_off(struct pci_dev *dev); + static inline void pci_msi_set_enable(struct pci_dev *dev, int enable) { u16 control; diff --git a/include/linux/pci.h b/include/linux/pci.h index a34df45..ef15f91 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -970,7 +970,6 @@ void pci_intx(struct pci_dev *dev, int enable); bool pci_intx_mask_supported(struct pci_dev *dev); bool pci_check_and_mask_intx(struct pci_dev *dev); bool pci_check_and_unmask_intx(struct pci_dev *dev); -void pci_msi_off(struct pci_dev *dev); int pci_set_dma_max_seg_size(struct pci_dev *dev, unsigned int size); int pci_set_dma_seg_boundary(struct pci_dev *dev, unsigned long mask); int pci_wait_for_pending(struct pci_dev *dev, int pos, u16 mask); diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index fcee8ea..54cefb4 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -3103,6 +3103,7 @@ EXPORT_SYMBOL_GPL(pci_check_and_unmask_intx); * If you want to use MSI, see pci_enable_msi() and friends. * This is a lower-level primitive that allows us to disable * MSI operation at the device level. + * Not for use by drivers. */ void pci_msi_off(struct pci_dev *dev) { @@ -3112,7 +3113,6 @@ void pci_msi_off(struct pci_dev *dev) if (dev->msix_cap) pci_msix_clear_and_set_ctrl(dev, PCI_MSIX_FLAGS_ENABLE, 0); } -EXPORT_SYMBOL_GPL(pci_msi_off); int pci_set_dma_max_seg_size(struct pci_dev *dev, unsigned int size) { -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html