Re: [PATCH] pci: iproc: fix PCIE_IPROC in Kconfig

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 24, 2015 at 12:33 AM, Ray Jui <rjui@xxxxxxxxxxxx> wrote:
> Make PCIE_IPROC depending on both OF and ARM and default to be disabled,
> so it cannot be accidentally enabled by other platforms
>
> PCIE_IPROC is meant to be enabled by a front-end bus driver. Curenntly
> it's enabled by PCIE_IPROC_PLTFM driver
>
> Signed-off-by: Ray Jui <rjui@xxxxxxxxxxxx>
> ---
>  drivers/pci/host/Kconfig |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index feccd0d..963b507 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -108,6 +108,8 @@ config PCI_VERSATILE
>
>  config PCIE_IPROC
>         tristate "Broadcom iProc PCIe controller"
> +       depends on OF && ARM
> +       default n
>         help
>           This enables the iProc PCIe core controller support for Broadcom's
>           iProc family of SoCs. An appropriate bus interface driver also needs

What pattern are you following?  There must be other drivers with
similar front-end bus driver schemes, and I'd rather copy their
Kconfig descriptions than invent something new.

With CONFIG_PCIE_IPROC_PLTFM, can we spell out "PLATFORM"?  Doesn't
seem like there's anything to gain by abbreviating it.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux