>>> On 12.03.15 at 00:10, <mcgrof@xxxxxxxxxxxxxxxx> wrote: > config X86_LOCAL_APIC > def_bool y > - depends on X86_64 || SMP || X86_32_NON_STANDARD || X86_UP_APIC || PCI_MSI > + depends on X86_64 || SMP || X86_32_NON_STANDARD || PCI_MSI I.e. building a 32-bit kernel with APIC support but with !SMP, !PCI_MSI, and !X86_32_NON_STANDARD will now be impossible. Surely not what the patch description says. > --- a/drivers/pci/Kconfig > +++ b/drivers/pci/Kconfig > @@ -5,6 +5,8 @@ config PCI_MSI > bool "Message Signaled Interrupts (MSI and MSI-X)" > depends on PCI > select GENERIC_MSI_IRQ > + select X86_LOCAL_APIC > + select X86_IO_APIC I don't see the need for the latter - MSI specifically works without any IO-APIC interaction. And for the former you should decide which way you want it - PCI_MSI select X86_LOCAL_APIC (probably the right thing in x86, but surely wrong everwhere else, i.e. this at least needs a condition tagged onto it) or X86_LOCAL_APIC depend on PCI_MSI; in no case should this be a forward _and_ reverse dependency. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
