Re: [PATCH] pci-versatile.c: Update for API change in list_for_each_entry()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 26, 2015 at 04:45:15PM +0100, Rafael J. Wysocki wrote:
> On Thursday, February 26, 2015 08:41:37 AM Linus Walleij wrote:
> > On Wed, Feb 25, 2015 at 4:15 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > 
> > > From: Joachim Nilsson <troglobit@xxxxxxxxx>
> > >
> > > In Linux 4.0-rc1 ARM Versatile PCI build fails to build due to what
> > > appears to be an API update.  This patch is a very simple correction,
> > > merely posted as a heads-up to the maintainers.  Hopefully a better
> > > fix can be forwarded to Linus.
> > >
> > > [arnd: the patch actually looks correct, so let's take this version]
> > >
> > > Signed-off-by: Joachim Nilsson <troglobit@xxxxxxxxx>
> > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > > ---
> > >
> > > Joachim reported the bug, and I independently found the same problem.
> > > The patch he sent to the list did not apply for me for an unknown reason,
> > > but I fixed it up and forward it now to the right list of recipients.
> > 
> > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> 
> Do I need to take this one?  Bjorn?

Yeah, if you don't mind, why don't you take it, Rafael.  I think it was
introduced by 872912352c5b ("Merge tag 'pm+acpi-3.20-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm").  I don't
really understand that commit, but it looks like this part of it is the
problem:

  -       list_for_each_entry(win, res, list) {
  ++      resource_list_for_each_entry(win, res, list) {

If you do, would you mind updating the subject line and adding these acks?

  PCI: versatile: Update for list_for_each_entry() API change

  Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
  Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux