Re: [PATCH v2] PCI: rcar: Add address check of mem_res

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 16, 2015 at 10:54:08AM +0900, Nobuhiro Iwamatsu wrote:
> lower 16 bits of the address, which is managed by mem_res need to be 0.
> This adds address check of lower 16 bits.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx>

Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
>  v2: Remove to before devm_kzalloc().
> 
>  drivers/pci/host/pci-rcar-gen2.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/host/pci-rcar-gen2.c b/drivers/pci/host/pci-rcar-gen2.c
> index d9c042f..e9617d3 100644
> --- a/drivers/pci/host/pci-rcar-gen2.c
> +++ b/drivers/pci/host/pci-rcar-gen2.c
> @@ -346,6 +346,9 @@ static int rcar_pci_probe(struct platform_device *pdev)
>  	if (!mem_res || !mem_res->start)
>  		return -ENODEV;
>  
> +	if (mem_res->start & 0xFFFF)
> +		return -EINVAL;
> +
>  	priv = devm_kzalloc(&pdev->dev,
>  			    sizeof(struct rcar_pci_priv), GFP_KERNEL);
>  	if (!priv)
> -- 
> 2.1.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux