Resend with correct ml address On: 03 February 2015 18:44, Phil Edworthy wrote: > Hi Iwamatsu-san, > > Hmm, this is odd as MSI works before and after your patch. Since bit 31 just > represents the value of MSICAP0[16].MSIE, I think this may just be used for > endpoints. > > However, you are correct that the bit used was wrong and so: > Acked-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Thanks > Phil > > On: 02 February 2015 05:05, Nobuhiro Iwamatsu wrote: > > > > Position of MSI enable bit is 31bit, not 28bit. > > This fixes position of MSI bit necessary to initialize MSI. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@xxxxxxxxxxx> > > --- > > drivers/pci/host/pcie-rcar.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/pcie-rcar.c b/drivers/pci/host/pcie-rcar.c > > index bb36e27..eb12659 100644 > > --- a/drivers/pci/host/pcie-rcar.c > > +++ b/drivers/pci/host/pcie-rcar.c > > @@ -505,7 +505,7 @@ static int rcar_pcie_hw_init(struct rcar_pcie *pcie) > > > > /* Enable MSI */ > > if (IS_ENABLED(CONFIG_PCI_MSI)) > > - rcar_pci_write_reg(pcie, 0x101f0000, PCIEMSITXR); > > + rcar_pci_write_reg(pcie, 0x801f0000, PCIEMSITXR); > > > > /* Finish initialization - establish a PCI Express link */ > > rcar_pci_write_reg(pcie, CFINIT, PCIETCTLR); > > -- > > 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
