On Monday, January 26, 2015 7:55 PM, Lucas Stach wrote: > > The DW PCIe MSI hardware does not support MSI-X irqs. Setting those up > failed as a side effect of a bug which was fixed by 91f8ae823f2b > (PCI: designware: Setup and clear exactly one MSI at a time). > > Now that this bug is fixed MSI-X irqs need to be rejected explicitly, > otherwise devices trying to use them may end up with incorrectly working > interrupts. Right. > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxxxxxxx> # 3.18 Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Best regards, Jingoo Han > --- > drivers/pci/host/pcie-designware.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c > index df781cdf13c1..17ca98657a28 100644 > --- a/drivers/pci/host/pcie-designware.c > +++ b/drivers/pci/host/pcie-designware.c > @@ -283,6 +283,9 @@ static int dw_msi_setup_irq(struct msi_controller *chip, struct pci_dev *pdev, > struct msi_msg msg; > struct pcie_port *pp = sys_to_pcie(pdev->bus->sysdata); > > + if (desc->msi_attrib.is_msix) > + return -EINVAL; > + > irq = assign_irq(1, desc, &pos); > if (irq < 0) > return irq; > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
