On Friday 16 January 2015 09:44:07 Yijing Wang wrote: > We want to make a generic pci_host_bridge, then we could > place common PCI infos like domain number in it. Ripping > out pci_host_bridge creation from pci_create_root_bus() > make code more better readability. Further more, we could > use the generic pci_host_bridge to hold host bridge specific > operations like pcibios_root_bridge_prepare(). > > Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx> > I assume this patch is doing the right thing, but the description above doesn't really tell me enough to be sure. This is supposed to be transparent to the callers, right? If so, please mention it explicitly in the text. Also you don't explain what the list of host bridges is used for. Maybe you can split this out into a separate patch so you have one patch that just moves code from one file to the other but no functional changes, and a second patch that exports pci_create_host_bridge and introduces the list, with an explanation of what it is used for. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
