On Wednesday 07 January 2015 13:49:50 Murali Karicheri wrote: > PCI devices on Keystone doesn't have correct dma_pfn_offset set. This patch > add capability to set the dma configuration such as dma-mask, dma_pfn_offset, > and dma ops etc using the information from DT. The prior RFCs and discussions > are available at [1] and [2] below. > > [2] : https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg790244.html > [1] : http://www.gossamer-threads.com/lists/linux/kernel/2024591 Looks all good to me in this version, I'm just unsure about one thing: > - Limit the of_iommu_configure to non pci devices My last recommendation was to pass the b/d/f number into of_pci_dma_configure to handle this correctly. What was your reason for not doing it in the end? We will likely have to change this again if we take your current version, but that can be a follow-up patch. I believe AMD requires it to use PCI on their their Seattle platform. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html