Re: [PATCH net]tg3: tg3_disable_ints using uninitialized mailbox value to disable interrupts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 20-12-2014 20:16, Nils Holland wrote:
On Sat, Dec 20, 2014 at 12:16:17PM -0800, Prashant Sreedharan wrote:

This driver bug was exposed because of the commit a7877b17a667 (PCI: Check only
the Vendor ID to identify Configuration Request Retry). Also this issue is only
seen in older generation chipsets like 5722 because config space write to offset
0 from driver is possible.

Fixed by initializing the interrupt mailbox registers before calling tg3_halt.

Please queue for -stable.

I gave this patch a try and can confirm what was to be expected: It
fixes the issue and the network interface is once again working
properly on my system. Thus, I guess the issue is adequately solved.

Thanks to everyone involved, especially to Marcelo for additional
debugging and the guys at Broadcom for the quick fix!

Greetings,
Nils

Same here, it works again.

Thanks!
Marcelo
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux