Re: [PATCH v2 3/4] ARM: mach-bcm: Enable PCIe support for iProc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/12/2014 9:02 AM, Arnd Bergmann wrote:
On Friday 12 December 2014 08:56:19 Ray Jui wrote:

diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index aaeec78..a13a0b2 100644
--- a/arch/arm/mach-bcm/Kconfig
+++ b/arch/arm/mach-bcm/Kconfig
@@ -19,6 +19,7 @@ config ARCH_BCM_IPROC
      select ARCH_REQUIRE_GPIOLIB
      select ARM_AMBA
      select PINCTRL
+    select PCIE_IPROC
      help
        This enables support for systems based on Broadcom IPROC architected SoCs.
        The IPROC complex contains one or more ARM CPUs along with common


No, just enable it in multi_v7_defconfig and bcm_defconfig.

       Arnd

Or can I simply have the PCIE_IPROC default to y in
drivers/pci/host/Kconfig? Note PCIE_IPROC depends on ARCH_BCM_IPROC. By
defaulting it to y, it will be automatically enabled for all iProc
family of SoCs.

I still think it's best not to turn it on automatically. The convention
for device drivers is to make them all optional.

What you can do however is to add

	depends on ARCH_BCM_IPROC || COMPILE_TEST

to the driver to do the reverse and not let the driver be turned on
unless IPROC is selected or you are just testing the build.
A lot of distros just turn on all drivers, so this way you wouldn't
accidentally enable it for a kernel that doesn't support IPROC.

	Arnd

Okay I'll do that. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux