RE: [PATCH RFC] pci: Control whether VFs are probed on pci_enable_sriov

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>>>> What's the end-game here? How eventually would this be controlled?
>>>You can probe any VF at the hypervisor through sysfs files

>>>(bind/unbind). You can also pass them through to a VM. Nothing
>>>changes.

>> If you're not planning on adding a logic to set this, why do we need to
>> add a parameter to pci_enable_sriov() - given that all callers use the
>> exact same logic?
>> [And I don't really think we'd want different devices to behave differently
>> by default; That would be confusing for users.]

>Currently the kerenl will call probe for any device for which there is
>a supporting driver and I did not want to change that.

But what's next? How will this feature be activated?

Adding a parameter to pci_enable_sriov() might give developers the false
impression they can change behavior by passing `0' to this function; 
But that shouldn't be the method to control this - we should have uniform 
control of the feature across different drivers, e.g., by an additional sysfs node.

<<attachment: winmail.dat>>


[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux