On Thu, Nov 20, 2014 at 04:31:45PM +0000, Marc Zyngier wrote: > Bjorn, Yijing, > > I've just realized that patch c167caf8d174 (PCI/MSI: Remove useless > bus->msi assignment) completely breaks MSI on arm64 when using the new > MSI stacked domain: > > This patch relies on architectures to implement either > pcibios_msi_controller() or arch_setup_msi_irq(). It turns out that with > stacked domains, none of this is actually necessary, as long as you can > access to the msi_controller. > > And everything was fine until this patch came around (and managed to > test on a system where the PCI devices are not directly attached to the > root bus). Of course, everything now breaks, as we cannot get to the MSI > controller (which contains the domain we allocate the MSIs from). > > In short, this patch breaks an important feature on which arm64 relies, > and I believe this patch should be reverted ASAP. I'm happy to revert it from pci/msi, but I think Thomas has already pulled it into his branch, so he'd have to drop it, too. Thomas, let me know if you want to do that. I suppose we could add a new patch to add it back, but that would leave bisection broken for the interval between c167caf8d174 and the patch that adds it back. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
