Re: Regression caused by "PCI: Shrink decoding-disabled window while sizing BARs"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[+cc Yinghai]

On Tue, Nov 18, 2014 at 4:34 AM, Thomas Petazzoni
<thomas.petazzoni@xxxxxxxxxxxxxxxxxx> wrote:
> Hello,
>
> On Tue, 18 Nov 2014 10:58:43 +0100, Thomas Petazzoni wrote:
>
>> Another issue (possibly related, or not), is the following compile time
>> warning:
>>
>> /home/thomas/projets/linux-2.6/drivers/pci/probe.c: In function ‘pci_read_bridge_mmio_pref’:
>> /home/thomas/projets/linux-2.6/drivers/pci/probe.c:430:5: warning: left shift count >= width of type
>>      base |= ((dma_addr_t) mem_base_hi) << 32;
>>      ^
>> /home/thomas/projets/linux-2.6/drivers/pci/probe.c:431:5: warning: left shift count >= width of type
>>      limit |= ((dma_addr_t) mem_limit_hi) << 32;
>>      ^
>>
>> This happens because dma_addr_t is 32 bits on ARM platforms, which
>> isn't properly taken into account by the commit that introduces support
>> for 64 bits DMA addresses.
>
> Not sure about this one: the commit introducing the issue is in
> next-20141117, but not in the current pci/next of Bjorn. Was it
> reverted? Am I looking at the wrong place?

Yes, that change (3a02517d5e2a ("PCI: Support 64-bit bridge windows if
we have 64-bit dma_addr_t")) is in my for-linus branch because it
fixes a regression and I intend to merge it for v3.18 (after we figure
out these issues, of course).

I saw this warning yesterday, but haven't heard from Yinghai yet.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux