On Mon, 17 Nov 2014, Bjorn Helgaas wrote: > Super. Thank you very much for taking care of this; it's a big weight > off my mind. > > You can add my Acked-by to these patches if you want it. I would > suggest a minor comment expansion here, just because the code *looks > like* it's setting up something to match a hardware device: > > > +/** > > + * pci_msi_domain_calc_hwirq - Generate a unique ID for an MSI source > > + * @dev: Pointer to the PCI device > > + * @desc: Pointer to the msi descriptor > > + * > > + * The ID number is only used within the irqdomain. > > Maybe include something like: > > This "irq_hw_number_t" is an opaque identifier used only by the > irqdomain code. > It does not correspond to any hardware implementation or register encoding. Yes, that's really a way better description of it. Thanks for having a look! tglx -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html