[CC'ing Arnd and RobH] On Tue, Nov 11, 2014 at 03:33:44PM +0000, Suravee Suthikulpanit wrote: > On 11/11/14 18:24, Will Deacon wrote: > >> @@ -313,6 +324,9 @@ static int gen_pci_probe(struct platform_device *pdev) > >> > return err; > >> > } > >> > > >> >+ pci->mchip = of_pci_find_msi_chip_by_node(of_parse_phandle(np, > >> >+ "msi-parent", 0)); > > This bit should be in the generic of_pci.c code and not duplicated for > > each host controller. > > > > Will > > I forgot to mention and include in the patch that we are also > introducing "msi-parent" binding to the generic host controller. I'll do > that in v2. > > Unless this is something that we would like to add to the generic OF > binding for PCI, I think it should be in the pci-host-generic.c. Is there a reason why we do *not* want to add this property to generic OF PCI binding ? Thanks, Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
