On Wed, Nov 12, 2014 at 8:32 PM, Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> wrote: > On Wed, Nov 12, 2014 at 10:51:31AM +0000, Ming Lei wrote: >> On Wed, Nov 12, 2014 at 5:58 PM, Lorenzo Pieralisi >> <lorenzo.pieralisi@xxxxxxx> wrote: >> > On Wed, Nov 12, 2014 at 02:12:12AM +0000, Ming Lei wrote: >> >> On Wed, Nov 12, 2014 at 2:24 AM, Lorenzo Pieralisi >> >> <lorenzo.pieralisi@xxxxxxx> wrote: >> >> > On Tue, Nov 11, 2014 at 02:02:20PM +0000, Ming Lei wrote: >> >> > >> >> > [...] >> >> > >> >> >> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296535.html >> >> >> > >> >> >> > Patch above is already queued and applies most of the changes you have posted >> >> >> > above. >> >> >> >> >> >> I should have looked at list first before writing the patch, :-( >> >> >> >> >> >> Could you make it more generic so that other ARCHs(at least ARM64) >> >> >> can benefit from it too? >> >> > >> >> > That's our current goal, we are carrying out clean-ups to remove arch >> >> > dependency and move code to the generic layer PCI layer. >> >> >> >> OK, I am glad to test them after you post them out. >> >> >> >> At least, the 'struct gen_pci' pointer can be put in driver data >> >> of the platform_device now, which may remove dependency on >> >> pci_sysdata in this driver. But ARCH's pcibios code still may >> >> access 'pci_sysdata', do you have patches or solution to handle >> >> this issue? >> > >> > I will consider adding struct gen_pci pointer as platform device >> > driver data, we are working on removing pci_sys_data dependency in the ARM >> > pcibios backend, and I do not think we are far from achieving that. >> >> Other ARCHs has sort of pcibios backend too, so that said it still >> depends on ARM or ARM64, doesn't it? > > Yes, so ? If you think there is a way to make this host controller work I mean suppose the driver/device is only for ARM and ARM64, it should be easy to support, and it may not be necessary to remove pci_sys_data dependency in the ARM, such as: - make a different code path for ARM64 - or like this patch to fake sysdata for ARM - or what ever > on all arches you fancy using it on with no arch dependency in a proper > way step up to the plate and post the code, we will duly review it. The only way I thought of is to bypass pcibios handling for the generic host controller, but it may not be agreed. Thanks, Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
