On Wed, Nov 12, 2014 at 7:30 PM, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > On Wed, Nov 12, 2014 at 7:29 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > > [] > >>> To prevent this, we detect a chain contains a Thunderbolt >>> device by checking the Thunderbolt PCI device id. >> >> I'm really not happy about checking a list of device IDs to identify >> Thunderbolt devices. Surely there's a better way, because a list like >> this has to be updated regularly. > > I recently proposed internally to use quirks (pci_fixup_early) for > that, but apparently Michael didn't have time to answer. It might be > he can just comment here since the patch already public. In any case: this will interfere with thunderbolt hotplug on Apple systems, where we do not have BIOS support and have to handle hotplug events and assign resources ourselves. So please add a DMI check for Apple (the reverse of what we do in http://lxr.free-electrons.com/source/drivers/thunderbolt/nhi.c?v=3.17#L664 ). Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
