On Wednesday 12 November 2014 14:14:29 Lorenzo Pieralisi wrote: > > > > Since this is now in the file in which it gets called, you can mark the > > function itself as 'static' and remove the extern declaration and inline > > wrapper from the header file. You can also avoid the #ifdef by doing > > It is not, it is in driver/pci/pci.c, it is called in probe.c. > > Maybe I can move the function to probe.c, but this would leave the > domain handling in two separate files. > > I can't remove the #ifdeffery in that domain_nr in pci_bus is #ifdeffed > too, unless I remove that #ifdef and I compile it in all the time. > Right, I see. Unless Bjorn has some other preference, I'd just leave it with your current version then. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html