On 6 November 2014 11:08, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> Add __init annotation to spear13xx_add_pcie_port(), because
> the spear13xx_add_pcie_port() is called only by spear13xx_pcie_probe()
> that was already marked as __init. Also, this patch fixes
> section mismatch warning.
>
> WARNING: drivers/pci/host/built-in.o(.text.unlikely+0x94): Section mismatch in reference from the function spear13xx_add_pcie_port()
> to the function .init.text:dw_pcie_host_init()
> The function spear13xx_add_pcie_port() references
> the function __init dw_pcie_host_init().
> This is often because spear13xx_add_pcie_port lacks a __init
> annotation or the annotation of dw_pcie_host_init is wrong.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> This patch is based on the submitted patch "[PATCH V2] PCI:
> spear: Add spear13xx before add_pcie_port/pcie_initt".
>
> drivers/pci/host/pcie-spear13xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/host/pcie-spear13xx.c b/drivers/pci/host/pcie-spear13xx.c
> index 63f869f..60f43cd 100644
> --- a/drivers/pci/host/pcie-spear13xx.c
> +++ b/drivers/pci/host/pcie-spear13xx.c
> @@ -269,8 +269,8 @@ static struct pcie_host_ops spear13xx_pcie_host_ops = {
> .host_init = spear13xx_pcie_host_init,
> };
>
> -static int spear13xx_add_pcie_port(struct pcie_port *pp,
> - struct platform_device *pdev)
> +static int __init spear13xx_add_pcie_port(struct pcie_port *pp,
> + struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> int ret;
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
