Hi Phil, On Fri, Oct 31, 2014 at 01:43:49PM +0000, Phil Edworthy wrote: > Hi Lorenzo, > > On 30 October 2014 11:45, Lorenzo wrote: > > Most if not all ARM PCI host controller device drivers either ignore the > > domain field in the pci_sys_data structure or just increment it every > > time a host controller is probed, using it as a domain counter. > > > > Therefore, instead of relying on pci_sys_data to stash the domain number > > in a standard location, ARM pcibios code can be moved to the newly > > introduced generic PCI domains code, implemented in commits: > > > > commit 41e5c0f81d3e676d671d96a0a1fafb27abfbd9 > > ("of/pci: Add pci_get_new_domain_nr() and of_get_pci_domain_nr()") > > > > commit 670ba0c8883b576d0aec28bd7a838358a4be1 > > ("PCI: Add generic domain handling") > > > > In order to assign a domain number dynamically, the ARM pcibios defines > > the function, called by core PCI code: > > > > void pci_bus_assign_domain_nr(...) > > > > that relies on a DT property to define the domain number or falls back to > > a counter; its usage replaces the current domain assignment code in PCI > > host controllers present in the kernel. > > > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > Cc: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > > Cc: Jingoo Han <jg1.han@xxxxxxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: Russell King <linux@xxxxxxxxxxxxxxxx> > > Cc: Mohit Kumar <mohit.kumar@xxxxxx> > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@xxxxxxx> > > This patch fixes a current problem with R-Car devices where there is an > internal PCI bridge and an external PCIe bridge on the devices. Both drivers > work independently but need to be on different domains. Just needed to enable > PCI_DOMAINS along with this. > I've done basic testing that the internal PCI and external PCIe work at the > same time. > > Acked-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> Thank you very much. Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html