Hello!
> From: Matthew Wilcox <matthew.r.wilcox@xxxxxxxxx>
> Date: Tue, 30 Sep 2014 13:41:07 -0400
> Subject: [PATCH] lspci: Add ability to filter by class code
>
> Extend the 'filter by device ID' functionality to allow optional
> specification of a device ID. For example, to list all USB controllers
> in the system made by Intel, specify:
>
> lspci -d 8086::0c03
I like the idea, but I see a couple of issues with the actual
implementation:
• I wonder if it could be useful to filter by prog-if in addition
to the class, or only on the class without its sub-class?
• Extending struct pci_filter breaks ABI (my fault in designing
the API years ago -- it would have been much better if the struct
were allocated by the library instead of the caller). Could you
please add symbol versioning for pci_filter_(init|match|parse_id)?
Have a nice fortnight
--
Martin `MJ' Mares <mj@xxxxxx> http://mj.ucw.cz/
Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth
Q: Who invented the first airplane that did not fly? A: The Wrong Brothers.
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
