> -----Original Message----- > From: Murali Karicheri [mailto:m-karicheri2@xxxxxx] > Sent: Tuesday, October 28, 2014 2:24 AM > To: Zhu Richard-R65037 > Cc: linux-pci@xxxxxxxxxxxxxxx; Guo Shawn-R65073; festevam@xxxxxxxxx; > l.stach@xxxxxxxxxxxxxx; tharvey@xxxxxxxxxxxxx; Zhu Richard-R65037 > Subject: Re: [PATCH v8 5/9] PCI: imx6: Add imx6sx pcie support > > > > dw_pcie_wr_own_conf(pp, PCI_BASE_ADDRESS_0, 4, 0); > > > > diff --git a/drivers/pci/host/pcie-designware.h > > b/drivers/pci/host/pcie-designware.h > > index 1a59600..6061355 100644 > > --- a/drivers/pci/host/pcie-designware.h > > +++ b/drivers/pci/host/pcie-designware.h > > @@ -75,7 +75,7 @@ struct pcie_host_ops { > > int (*wr_other_conf)(struct pcie_port *pp, struct pci_bus *bus, > > unsigned int devfn, int where, int size, u32 val); > > int (*link_up)(struct pcie_port *pp); > > - void (*host_init)(struct pcie_port *pp); > > + int (*host_init)(struct pcie_port *pp); > Richard, > > Please update the drivers/pci/host/pci-keystine.c as well for > host_init() as pci-keystone is already merged to v3.18rc1. Please update the > driver if you are changing API for pcie-designware core. > > Murali Got that, thanks for your notice. Best Regards Richard Zhu > > void (*msi_set_irq)(struct pcie_port *pp, int irq); > > void (*msi_clear_irq)(struct pcie_port *pp, int irq); > > u32 (*get_msi_data)(struct pcie_port *pp); diff --git > > a/drivers/pci/host/pcie-spear13xx.c > > b/drivers/pci/host/pcie-spear13xx.c > > index 6dea9e4..b8fd76b 100644 > > --- a/drivers/pci/host/pcie-spear13xx.c > > +++ b/drivers/pci/host/pcie-spear13xx.c > > @@ -258,10 +258,12 @@ static int spear13xx_pcie_link_up(struct pcie_port *pp) > > return 0; > > } > > > > -static void spear13xx_pcie_host_init(struct pcie_port *pp) > > +static int spear13xx_pcie_host_init(struct pcie_port *pp) > > { > > spear13xx_pcie_establish_link(pp); > > spear13xx_pcie_enable_interrupts(pp); > > + > > + return 0; > > } > > > > static struct pcie_host_ops spear13xx_pcie_host_ops = { > > - > Murali Karicheri > Linux Kernel, Texas Instruments -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
