On Thu, Oct 30, 2014 at 03:14:17PM +0100, Arnd Bergmann wrote: > On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: > > On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > > > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > > > It enables hibernation if the function is set in coreConsultant. > > > > > > > > Suggested-by: Felipe Balbi <balbi@xxxxxx> > > > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > > > > > > > > > Something went wrong with the Signed-off-by lines here. > > > You should never add someone else's Signed-off-by below yours. > > > > > > I took a brief look at the entire series and the patches all look good > > > to me, but you have made the same mistake with the Signed-off-by > > > multiple times. > > > > there are no mistakes, I just asked Huang to resend what I had on my > > testing/next because it had not been sent to devicetree mailing list. > > > > It's definitely a tricky question what the right Signed-off-by > chain is in this case, I guess strictly speaking it could have > been > > Suggested-by: Felipe Balbi <balbi@xxxxxx> > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > > which could correctly track where the patches went, but it's also > somewhat silly. somewhat ? You don't need to be so black and white. -- balbi
Attachment:
signature.asc
Description: Digital signature
