On Tue, Oct 28, 2014 at 08:38:56AM -0500, Felipe Balbi wrote: > Hi, > > almost there... > > On Tue, Oct 28, 2014 at 07:54:40PM +0800, Huang Rui wrote: > > diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h > > index 8b94ad5..b08a2f9 100644 > > --- a/drivers/usb/dwc3/core.h > > +++ b/drivers/usb/dwc3/core.h > > @@ -699,6 +699,7 @@ struct dwc3_scratchpad_array { > > * @rx_detect_poll_quirk: set if we enable rx_detect to polling lfps quirk > > * @dis_u3_susphy_quirk: set if we disable usb3 suspend phy > > * @dis_u2_susphy_quirk: set if we disable usb2 suspend phy > > + * @amd_nl_plat: set if we use AMD NL platform > > however, as I mentioned before, the core shouldn't have to know that > it's running on an AMD platform. We already support several different > platforms (OMAP5, AM437x, DRA7xx, Exynos5, Exynos7, Qcom, Merrifield, > Baytrail, Braswell, HAPS PCIe, and STiH407) and none of them get their > $my_awesome_platform flag in dwc3, why should AMD be any different ? > > This is the only part of $subject that I cannot accept because it would > mean we would be giving AMD a special treatment when there shouldn't be > any, for anybody. > That's because I used this flag to enable below quirks on AMD NL FPGA board, and FPGA flag only can be detected on core. Can I set disable_scramble_quirk, dis_u3_susphy_quirk, and dis_u2_susphy_quirk for all the FPGA platforms? if (dwc->amd_nl_plat && dwc->is_fpga) { dwc->disable_scramble_quirk = true; dwc->dis_u3_susphy_quirk = true; dwc->dis_u2_susphy_quirk = true; } Thanks, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html