On Thu, Oct 23, 2014 at 05:52:06PM +0100, Jason Gunthorpe wrote: > On Thu, Oct 23, 2014 at 12:27:31PM +0100, Lorenzo Pieralisi wrote: > > > I think that by removing that, we could switch to CONFIG_PCI_DOMAINS_GENERIC > > on ARM32. I will remove the dependency in drivers/pci/host/pci-mvebu.c > > introduced by commit 2613ba48. pci_sys_data.domain is always 0 in that > > driver so its usefulness is doubtful, comments welcome, copied Jason in > > if he has comments. > > pcie-mvebu is like all the other new drivers, each top level DT node > that introduces the interface should have a unique domain number. It > would be very strange (and currently unsupported by the driver) to > ever have more than 1 mvebu top level node in any DT. Which as a matter of fact I should take as pci_sys_data.domain is useless on pci-mvebu.c, since that value will always be 0 (at least it is in the current driver): #ifdef CONFIG_PCI_DOMAINS domain = sys->domain; #endif Am I missing something ? Is that domain number meant to be used for anything else ? Thanks, Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
