Re: [PATCH V2] PCI: imx6: Wait the clocks to stabilize after ref_en

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Richard,

On Fri, Oct 24, 2014 at 12:36 AM, Richard Zhu <richard.zhu@xxxxxxxxxxxxx> wrote:
> From: Richard Zhu <r65037@xxxxxxxxxxxxx>
>
> For boards without a reset GPIO we skip the delay between enabling the
> pcie_ref_clk and touching the RC registers for configuration.
> This hangs the system if there isn't a proper delay to ensure the clocks
> are settled in the DW PCIe core.
>
> Also iMX6Q always needs an additional 10us delay to make sure the reset
> is propagated through the core, as we don't have an explicitly
> controlled reset input on this SoC.
>
> Signed-off-by: Richard Zhu <richard.zhu@xxxxxxxxxxxxx>
> Tested-by: Tim Harvey <tharvey@xxxxxxxxxxxxx>
> Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
> Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>

The previous Tested-by tags that myself and Tim gave were for the
previous version of the patch without the delay.

I tested this new version of the patch now and you have my new tag :-)

Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>

I would suggest you to resed this patch (you can add Lucas's Acked-by)
and also make sure to copy Bjorn so that it can be applied to 3.18 as
a fix.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux