> -----Original Message----- > From: Fabio Estevam [mailto:festevam@xxxxxxxxx] > Sent: Friday, October 24, 2014 9:51 AM > To: Zhu Richard-R65037 > Cc: linux-pci-owner@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Guo Shawn- > R65073; Lucas Stach; Tim Harvey; Bjorn Helgaas > Subject: Re: [PATCH v2 2/5] PCI: imx6: wait the clocks to stabilize after > ref_en > > Hi Richard, > > On Tue, Sep 23, 2014 at 1:11 AM, Richard Zhu <r65037@xxxxxxxxxxxxx> wrote: > > - a while delay is mandatory required after pcie_ref_clk_en is set. > > Otherwise, the system would be hang on imx6qdl ard boards, because > > that imx6qdl boards don't have the reset_gpio. > > - the clocks should be stable already after the "clk_prepare_enable" > > is return. So I think it's ok to move the usleep delay after the > > pcie_ref_en is set. > > > > Signed-off-by: Richard Zhu <r65037@xxxxxxxxxxxxx> > > Tested-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > Without this patch we notice that the kernel does not boot anymore since > commit 3fce0e882f61 (PCI: imx6: Delay enabling reference clock for SS until > it stabilizes) on a system that does not pass the PCI gpio reset in the dtb. > This causes a regression on mx6 nitrogen boards. > > I would suggest that you resend this patch only so that it could be applied > into 3.18 as a bug fix. Okay, I would send out the patch today. Best Regards Richard Zhu ��.n��������+%������w��{.n�����{���"�)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
