On Thu, Oct 02, 2014 at 11:33:15AM +0100, Liviu Dudau wrote: > On Thu, Oct 02, 2014 at 05:07:29AM +0100, matt@xxxxxxxxxxxx wrote: > > From: Matthew Minter <matt@xxxxxxxxxxxx> > > > > Hi Matthew, > > Some comments below: Hi Liviu, Thank you very much for reviewing this! Sorry that I didn't notice your comments until later (mutt email-reading snafu on my end), so I duplicated some of your thoughts. This was just out of my ignorance, not because I'm taking issue with your comments. > > -static struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > +struct pci_host_bridge *find_pci_host_bridge(struct pci_bus *bus) > > When I did the same thing in one of the versions of my generic host bridge series, > Bjorn has mentioned that he would like the name to be changed to pci_xxxxx to > make clear that the function is now public. This particular one is not a big deal to me because it's in drivers/pci/pci.h, which is really only for use inside the PCI core. It's when we expose things in include/linux/pci.h, and especially when we export things for use by modules, that I think we should be careful to use a consistent namespace. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
