RE: [PATCH v3 2/9] PCI: imx6: enable pcie on imx6qdl sabreauto

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Best Regards
Richard Zhu

> -----Original Message-----
> From: Lucas Stach [mailto:l.stach@xxxxxxxxxxxxxx]
> Sent: Monday, September 29, 2014 5:57 PM
> To: Zhu Richard-R65037
> Cc: linux-pci-owner@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; Guo Shawn-
> R65073; festevam@xxxxxxxxx; tharvey@xxxxxxxxxxxxx
> Subject: Re: [PATCH v3 2/9] PCI: imx6: enable pcie on imx6qdl sabreauto
> 
> Am Montag, den 29.09.2014, 13:03 +0800 schrieb Richard Zhu:
> > - enable pcie on imx6qdl sabreauto boards.
> >
> > Signed-off-by: Richard Zhu <r65037@xxxxxxxxxxxxx>
> > Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > index 009abd6..d6040a5 100644
> > --- a/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-sabreauto.dtsi
> > @@ -410,6 +410,10 @@
> >  	};
> >  };
> >
> > +&pcie {
> > +	status = "okay";
> > +};
> > +
> >  &pwm3 {
> >  	pinctrl-names = "default";
> >  	pinctrl-0 = <&pinctrl_pwm3>;
> 
> The dts changes have a wrong prefix. They are not PCI subsystem patches, but
> arch patches for i.MX and should be applied by Shawn. So prefix needs to be
> ARM: imx6XX: ...
> 
> Also I would recommend that you sort them to the end of the series so make it
> easy for Bjorn and Shawn to see where the slit between the two is. Don't
> intermix those changes in the series, it certainly isn't needed here.
> 
[Richard] Ok, no problem. Thanks.
> Regards,
> Lucas
> --
> Pengutronix e.K.             | Lucas Stach                 |
> Industrial Linux Solutions   | http://www.pengutronix.de/  |

��.n��������+%������w��{.n�����{���"�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux