[PATCH v2 2/2] PCI/MSI: Remove the redundant irq_set_msi_desc()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Irq and msi_desc will be associated in arch MSI
setup code regardless of MSI or MSI-X type.
The irq_set_msi_desc() in msix_program_entries()
is redundant.

The typical MSI setup flow:
pci_enable_msix()
	msix_capability_init()
		arch_setup_msi_irqs()
			native_setup_msi_irqs()	e.g in x86
				setup_msi_irq()
					irq_set_msi_desc_off() <---

Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
---
 drivers/pci/msi.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c
index e0916ad..48eae97 100644
--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -673,7 +673,6 @@ static void msix_program_entries(struct pci_dev *dev,
 						PCI_MSIX_ENTRY_VECTOR_CTRL;
 
 		entries[i].vector = entry->irq;
-		irq_set_msi_desc(entry->irq, entry);
 		entry->masked = readl(entry->mask_base + offset);
 		msix_mask_irq(entry, 1);
 		i++;
-- 
1.7.1

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux