Re: [PATCH v3 3/3] PCI: Layerscape: Add Layerscape PCIe driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Scott,

Please see my comments inline.

On 2014年09月24日 05:25, Scott Wood wrote:
On Tue, 2014-09-23 at 22:29 +0800, Minghuan Lian wrote:
diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 34134d6..7c49456 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -82,4 +82,11 @@ config PCIE_XILINX
  	  Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
  	  Host Bridge driver.
+config PCI_LAYERSCAPE
+	bool "Freescale Layerscape PCIe controller"
+	select PCIE_DW
+	select MFD_SYSCON
+	help
+	  Say Y here if you want PCIe controller support on Layerscape SoCs.
+
  endmenu
Are you sure there are no dependencies for this to build?  At the least
you need OF.

I think you should also be selecting REGMAP.
[Minghuan] Yes, it does need OF. I will add 'depends on OF' next version.
Because MFS_SYSCON will select REGMAP, so I think it is enough to select MFS_SYSCON.

-Scott



--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux