Hi Bjorn, On 22 September 2014 22:01, Bjorn wrote: > On Mon, Sep 22, 2014 at 10:51:07AM +0100, Phil Edworthy wrote: > > The Renesas R-Car devices (r8a7790 and r8a7791) use two PCI controller > drivers, > > one for an external PCIe slot, the other for an internal PCI bridge to USB > > controllers. > > > > However, they currently do not work at the same time as they use the > same PCI > > domain and use the same root bus number. We can't use different root > bus numbers > > due to the way root bus numbers are assigned in pcibios_init_hw() in > > arch/arm/kernel/bios32.c. > > > > Since the two PCI controllers are completely independent, I think it makes > sense > > to use different PCI domains for them. > > > > I've marked the third patch as RFC as I am not sure of the impact of > enabling > > PCI domains for all ARM devices. In the march to 'one kernel to rule them > all', > > I steered clear of mach specific changes. > > > > These patches require the following patch from Liviu Dudau: > > [PATCH v11 07/10] OF: Introduce helper function for getting PCI > domain_nr > > Based on comments on this patch from Jason Gunthorpe, there is still the > issue > > that the domain numbers may change depending on the ordering at probe > time. > > However, this can be fixed later on by adding the entries in the DT files. > > > > > > Phil Edworthy (3): > > PCI: rcar-pcie: Add call to get domain nr > > PCI: rcar-internal-pci: Add call to get domain nr > > ARM: Enable PCI domains > > I'm deferring these for now because they depend on Liviu's work, which I > haven't merged yet, and I suspect some minor adaptation will be required > here. > > For what it's worth, I agree with Rob's hesitation about mixing lookup with > domain number allocation in of_pci_get_domain_nr(). That seems > unnecessarily complicated. I could create patches to add an optional "pci-domain" property for the R-Car PCI drivers, and just attempt to get the property in the drivers. If not found, the drivers will assume the domain is 0. We would then have fixed PCI domain numbering and I don't have to worry about Liviu's work. Would that be ok? Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
