On Wed, Aug 13, 2014 at 11:20:32AM -0600, Bjorn Helgaas wrote: > On Fri, Aug 01, 2014 at 04:58:34PM +0530, Sachin Kamat wrote: > > We get the following error when built as a module. Though the general fix would > > be in this case to export the below mentioned symbols, considering that > > dw_pcie_host_init is marked with __init and other PCI drivers do not support > > modular build, I have disabled building this driver as a module too. > > > > ERROR: "dw_pcie_host_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_handle_msi_irq" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_msi_init" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_write" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_cfg_read" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_setup_rc" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > ERROR: "dw_pcie_link_up" [drivers/pci/host/pcie-spear13xx.ko] undefined! > > make[1]: *** [__modpost] Error 1 > > make: *** [modules] Error 2 > > > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxxx> > > Applied with ack and reviewed-by from Viresh and Jingoo to pci/spear for > v3.17, thanks! Sorry, I misplaced this somehow. I did it again and it's now in my for-linus branch, so it should still make it for v3.17. Sorry about that. > > --- > > drivers/pci/host/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig > > index 8922c37..90f5cca 100644 > > --- a/drivers/pci/host/Kconfig > > +++ b/drivers/pci/host/Kconfig > > @@ -56,7 +56,7 @@ config PCI_HOST_GENERIC > > controller, such as the one emulated by kvmtool. > > > > config PCIE_SPEAR13XX > > - tristate "STMicroelectronics SPEAr PCIe controller" > > + bool "STMicroelectronics SPEAr PCIe controller" > > depends on ARCH_SPEAR13XX > > select PCIEPORTBUS > > select PCIE_DW > > -- > > 1.8.1.2 > > -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
