On Thu, Sep 04, 2014 at 04:18:43PM -0600, Bjorn Helgaas wrote: > On Thu, Sep 04, 2014 at 04:00:44PM -0600, Bjorn Helgaas wrote: > > On Mon, Aug 11, 2014 at 11:16:50AM +0100, Matthew Minter wrote: > > > It seems that by coincidence, my testing boxes did not have any > > > devices which needed the PCI_INTERRUPT_PIN fixed up. Therefore I had > > > not noticed the fact the fixed value was not used in the enable path. > > > > > > I would assume that someone with a different setup would have had a > > > problem there however so thank you for pointing out this bug. I have > > > integrated your fix into version 2 of the patch set. > > > > I'm dropping this series and I'll watch for v2. > > BTW, when you do repost this, the individual patches need changelogs, and > the summary (subject lines) can be a little shorter and more specific, > e.g., no need to mention "untested", but "accomodate new irq init code" > doesn't really convey much information to someone who is looking only at > the arch/m68k commits. And they need Signed-off-by tags. See Documentation/SubmittingPatches for more details. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html