On Thursday 04 September 2014 14:14:48 Arnd Bergmann wrote: > > My impression is that you have two distinct MSI controller > implementations, one for LS1021A and the other one for everything > else. How about using separate pcie_host_ops for them, possibly > also moving them into separate files? > One more thing: you should really use the msi-parent property to find the MSI controller: Sooner or later this PCI block is likely to end up in a real product that has GICv2m or GICv3 support, so you will have to pick which of the two MSI controllers to use. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html