Re: [PATCH v4 01/11] cpumask: factor out show_cpumap into separate helper function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 04/09/14 12:25, Peter Zijlstra wrote:
On Thu, Sep 04, 2014 at 11:43:18AM +0100, Sudeep Holla wrote:
You could make it bitmap_copy_to_buf() I suppose, and then have a
cpumask inline wrapper, to be fully consistent with the rest of the
implementations.


I liked the second approach, how about patch below ?
If will munge it into original patch.

Looks good, one more nit if you will permit :-)


Ofcourse :)

+int bitmap_copy_to_pagebuf(bool list, const unsigned long *maskp, char *buf)

Maybe s/copy/print/ or something? Its not really a 'copy' as such since
it very much transforms the bitmap.


Makes sense, will update accordingly.

Regards,
Sudeep

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux