Re: pciehp PCI_BASE_CLASS_DISPLAY check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 27, 2014 at 10:21 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> On Wed, Aug 27, 2014 at 3:03 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote:
>
>>
>> Only pciehp_configure_device() has the PCI_BASE_CLASS_DISPLAY check.
>
> That commit actually split the loop to two loops, so second loop still
> have check.
>
> but later
>
> | Author: Praveen Kalamegham <praveen@xxxxxxxxxx>
> | Date:   Wed May 19 17:03:12 2010 -0500
> |
> |    PCI: hotplug: pciehp: Removed check for hotplug of display devices
> |
> |    Removed check to prevent hotplug of display devices within pciehp.
> |    Originally this was thought to have been required within the PCI
> |    Hotplug specification for some legacy devices.  However there is
> |    no such requirement in the most recent revision. The check prevents
> |    hotplug of not only display devices but also computational GPUs
> |    which require serviceability.
>
> only removed the first one in pciehp_configure_device().
>
> So you can drop that checking.

Great, thanks!  I missed the fact that the check was there before.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux