On Thursday, August 14, 2014 5:42 PM, Lucas Stach wrote: > Am Freitag, den 01.08.2014, 19:42 +0900 schrieb Jingoo Han: > > On Friday, August 01, 2014 6:10 PM, Lucas Stach wrote: > > > > > > The driver had checks for this sprinkled all over. As we call > > > sys_to_pcie() before every instance of this check, we can as well > > > move the check to this single location to make things clear. > > > > > > Removing the statements after BUG[_ON]() is safe as the kernel > > > is halted at this point anyway. > > > > > > Signed-off-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > > > > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > Does this mean this addresses your concerns with the original series and > you are okay with it now? If so please provide an Ack to the patches of > this series also, so Bjorn knows if he can pick those up. Do you mean "[PATCH 0/4] PCI: designware: init order/resource alloc fixes"? Sorry , I didn't review it. Also, I am not sure when I review it. Mohit, Would you review Lucas's patch? Best regards, Jingoo Han > > Thanks, > Lucas > > > > > --- > > > This is a follow on patch to the series > > > "PCI: designware: init order/resource alloc fixes", which > > > addresses Jingoos review feedback, so this series should > > > be hopefully good to go now. > > > --- > > > > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
