On Wednesday, August 06, 2014 5:39 PM, Lucas Stach wrote: > > Am Mittwoch, den 06.08.2014, 10:02 +0530 schrieb Pratyush Anand: > > On Wed, Aug 06, 2014 at 02:26:10AM +0800, Fabio Estevam wrote: > > > Hi, > > > > > > I am running linux-next 20140805 on a imx6q-sabresd board and noticed > > > the following error: > > > > > > root@freescale /$ dmesg | grep pci > > > [ 0.168095] imx6q-pcie 1ffc000.pcie: missing *config* reg space > > > [ 0.501019] imx6q-pcie 1ffc000.pcie: phy link never came up > > > [ 0.501579] imx6q-pcie 1ffc000.pcie: PCI host bridge to bus 0000:00 > > > > > > This 'missing *config* reg space' was introduced by: > > > > dev_err printing the above message should be dev_dbg until all the > > platform specifies its configuration space definition through *reg* > > instead of *ranges*. > > > No it's completely right. Printing errors actually triggers people to > fix their DTs. I agree with Lucas Stach's opinion. Printing errors is necessary to let people change to fix the DT. According to the DT spec, using *ranges* is wrong. So, dev_err() can be used. > > > > commit 4dd964df36d0e548e1806ec2ec275b62d4dc46e8 > > > Author: Kishon Vijay Abraham I <kishon@xxxxxx> > > > Date: Thu Jul 17 14:30:40 2014 +0530 > > > > > > PCI: designware: Look for configuration space in 'reg', not 'ranges' > > > > > > The configuration address space has so far been specified in *ranges*, > > > however it should be specified in *reg* making it a platform MEM resource. > > > Hence used 'platform_get_resource_*' API to get configuration address space > > > in the designware driver. > > > > > > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx> > > > Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > > Acked-by: Mohit Kumar <mohit.kumar@xxxxxx> > > > Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx> > > > Cc: Jason Gunthorpe <jgunthorpe@xxxxxxxxxxxxxxxxxxxx> > > > Cc: Marek Vasut <marex@xxxxxxx> > > > Cc: Arnd Bergmann <arnd@xxxxxxxx> > > > > > > Wouldn't this break dt compatibility? > > > > In spite of the above missing *config* message, your system should > > work fine. This patch should not affect any older platform.They will > > assign their cfg space through restype == 0. > > > As Pratyush said things should work fine despite this warning. I'll send > a DT patch out to Shawn today to get rid of this warning. Good! :-) Best regards, Jingoo Han > > Regards, > Lucas > -- > Pengutronix e.K. | Lucas Stach | > Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
