Hi, patch looks good. A correction in pm8001_request_irq might be added too to allow the INT-X path when pm8001_setup_msix fails, but that is not part of this fix. Tomas Reviewed-by: Tomas Henzl <thenzl@xxxxxxxxxx> On 07/16/2014 08:05 PM, Alexander Gordeev wrote: > When a call to request_irq() failed pm8001_setup_msix() > still returns the success. This udate fixes the described > misbehaviour. > > Signed-off-by: Alexander Gordeev <agordeev@xxxxxxxxxx> > Cc: xjtuwjp@xxxxxxxxx > Cc: lindar_liu@xxxxxxxxx > Cc: linux-scsi@xxxxxxxxxxxxxxx > Cc: linux-pci@xxxxxxxxxxxxxxx > Acked-by: Jack Wang <xjtuwjp@xxxxxxxxx> > --- > drivers/scsi/pm8001/pm8001_init.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c > index e90c89f..e837ece 100644 > --- a/drivers/scsi/pm8001/pm8001_init.c > +++ b/drivers/scsi/pm8001/pm8001_init.c > @@ -744,9 +744,10 @@ static u32 pm8001_setup_msix(struct pm8001_hba_info *pm8001_ha) > pm8001_ha->irq_vector[i].irq_id = i; > pm8001_ha->irq_vector[i].drv_inst = pm8001_ha; > > - if (request_irq(pm8001_ha->msix_entries[i].vector, > + rc = request_irq(pm8001_ha->msix_entries[i].vector, > pm8001_interrupt_handler_msix, flag, > - intr_drvname[i], &(pm8001_ha->irq_vector[i]))) { > + intr_drvname[i], &(pm8001_ha->irq_vector[i])); > + if (rc) { > for (j = 0; j < i; j++) > free_irq( > pm8001_ha->msix_entries[j].vector, -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html