On 11 July 2014 03:09, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > I guess I'm obsessive, but I think it's nice when people run > "git log --oneline" on the file or directory they're changing, > and then follow the existing style. > > In this case, that would lead to a subject line like: > > PCI: spear: Add PCIe driver for ST Microelectronics SPEAr13xx Correct. > On Thu, Jul 10, 2014 at 12:56:32PM +0530, Viresh Kumar wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 702ca10..443dd05 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -6820,6 +6820,12 @@ S: Maintained >> F: Documentation/devicetree/bindings/pci/host-generic-pci.txt >> F: drivers/pci/host/pci-host-generic.c >> >> +PCIE DRIVER FOR ST SPEAR13XX >> +M: Mohit Kumar <mohit.kumar@xxxxxx> >> +L: linux-pci@xxxxxxxxxxxxxxx >> +S: Maintained >> +F: drivers/pci/host/pcie-spear13xx.c > > Wildcards work here, so you could follow the lead of IMX6, MVEBU, RCAR, > and DESIGNWARE and use: > > F: drivers/pci/host/*spear* Ok. >> --- /dev/null >> +++ b/drivers/pci/host/pcie-spear13xx.c >> ... >> +#define PCI_CAP_ID_EXP_OFFSET 0x70 > > A nit, but I'd use a name like EXP_CAP_ID_OFFSET to make it > more clear that this is specific to SPEAr, not something from > the PCI specs. Sure. -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
