From: Ken Helias <kenhelias@xxxxxxxxxxx> Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias <kenhelias@xxxxxxxxxxx> Cc: linux-pci@xxxxxxxxxxxxxxx --- drivers/pci/setup-bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c index fd9b545..77ceaab 100644 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@ -167,7 +167,7 @@ static void pdev_sort_resources(struct pci_dev *dev, struct list_head *head) } } /* Insert it just before n*/ - list_add_tail(&tmp->list, n); + list_add_before(&tmp->list, n); } } -- 2.0.0 -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
