Re: [PATCH 3/3] edac: remove the unnecessary checking for pci_bus_add_device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 29, 2014 at 12:01 AM, Yijing Wang <wangyijing@xxxxxxxxxx> wrote:
> Pci_bus_add_device() always return 0, remove the unnecessary
> checking for pci_bus_add_device().
>
> Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
> ---
>  drivers/edac/i82875p_edac.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/edac/i82875p_edac.c b/drivers/edac/i82875p_edac.c
> index 8d0450b..8705ba6 100644
> --- a/drivers/edac/i82875p_edac.c
> +++ b/drivers/edac/i82875p_edac.c
> @@ -293,12 +293,7 @@ static int i82875p_setup_overfl_dev(struct pci_dev *pdev,
>                 if (dev == NULL)
>                         return 1;
>
> -               err = pci_bus_add_device(dev);
> -               if (err) {
> -                       i82875p_printk(KERN_ERR,
> -                               "%s(): pci_bus_add_device() Failed\n",
> -                               __func__);
> -               }
> +               pci_bus_add_device(dev);
>                 pci_bus_assign_resources(dev->bus);
>         }

Bjorn,

At same time, can you please apply

http://patchwork.ozlabs.org/patch/242480/

PCI, EDAC: fix ordering assign resource and bus_add

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [DMA Engine]     [Linux Coverity]     [Linux USB]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Greybus]

  Powered by Linux