On Friday, May 09, 2014 6:10 PM, Geert Uytterhoeven wrote: > On Fri, May 9, 2014 at 11:03 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > The pci-rcar driver is enabled for compile tests, and this has > > now shown that the driver cannot build without CONFIG_OF, > > following the inclusion of f8f2fe7355fb "PCI: rcar: Use new OF > > interrupt mapping when possible": > > > > drivers/built-in.o: In function `rcar_pci_map_irq': > > :(.text+0x1cc7c): undefined reference to `of_irq_parse_and_map_pci' > > > > As pointed out by Ben Dooks and Geert Uytterhoeven, this is actually > > supposed to build fine, which we can achieve if we make the > > declaration of of_irq_parse_and_map_pci conditional on CONFIG_OF > > and provide an empty inline function otherwise, as we do for > > a lot of other of interfaces. > > > > This lets us build the rcar_pci driver again without CONFIG_OF > > for build testing. All platforms using this driver select OF, > > so this doesn't change anything for the users. > > Thanks! > > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > > Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> > > Cc: Magnus Damm <damm@xxxxxxxxxxxxx> > > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Cc: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx> > > Cc: linux-pci@xxxxxxxxxxxxxxx > > Cc: linux-sh@xxxxxxxxxxxxxxx > > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx> Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
