On Thursday 15 May 2014 08:16:16 Rob Herring wrote: > On Thu, May 15, 2014 at 7:39 AM, Will Deacon <will.deacon@xxxxxxx> wrote: > > On Wed, May 14, 2014 at 03:01:35PM +0100, Rob Herring wrote: > >> On Wed, May 7, 2014 at 11:07 AM, Will Deacon <will.deacon@xxxxxxx> wrote: > >> > When targetting ARCH_MULTIPLATFORM, we may include support for SoCs with > >> > PCI-capable devices (e.g. mach-virt with virtio-pci). > >> > > >> > This patch allows PCI support to be selected for these SoCs by selecting > >> > CONFIG_MIGHT_HAVE_PCI when CONFIG_ARCH_MULTIPLATFORM=y. > >> > >> I generally think we should select all options for multi-platform that > >> only serve to hide other options like this. > >> > >> You should remove the MIGHT_HAVE_PCI selections from all the > >> multi-platform enabled platforms as well. > > > > Something like the diff below? > > Yes, but that raises another question as to what do we do with > PCI_DOMAINS? Probably should be a PCI host driver select, or given how > little code it controls it could just be removed. Anyway, that's a > problem for another day (or patch). > > So with the below part added: > > Acked-by: Rob Herring <robh@xxxxxxxxxx> I think we should also 'select PCI_DOMAINS if PCI' for multiplatform, but I agree it doesn't have to be in this patch. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
