On Wed, Apr 30, 2014 at 2:51 PM, Bjorn Helgaas <bhelgaas@xxxxxxxxxx> wrote: > On Wed, Apr 30, 2014 at 3:33 PM, Yinghai Lu <yinghai@xxxxxxxxxx> wrote: >> On system with 16 PCI express hotplug slots, customer complain every slot >> will report "Command not completed in 1000 msec" during initialization. >> >> Intel says that we should only wait command complete only for >> Electromechanical Interlock Control >> Power Controller Control >> Power Indicator Control >> Attention Indicator Control >> >> System with AMD/Nvidia chipset have same problem. > > Do you have a datasheet reference for any of these parts? Do we have > any way of identifying the affected parts? Is it *all* Intel parts, > *all* AMD parts, *all* Nvidia parts? For intel: Nehalem, westmere, sndbridge, ivybridge. For nvidia, only according to boot log for old systems with chipset: ck804 and mcp55. > > I want to have a comment in the code because we basically have two > strategies for dealing with Command Complete. Both are legal > according to the PCIe spec, and you're changing from strategy A to > strategy B because B works better on these parts. We need a hint in > the code that tells us not to change from B back to A and why. > Otherwise some future programmer is likely to change back to A, which > will break your box again. ok, will try to add comment about the change. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
