On Fri, Apr 04, 2014 at 09:48:52AM +0800, Yijing Wang wrote: > Hi Bjorn, > Jon seems to send a patch to fix this long ago. Link: http://patchwork.ozlabs.org/patch/191054/ > But this patch cannot be applied now. I think we can just set smpss = 0 in this function as the default value. Yep. It's ugly, but I don't have time to try to make it prettier. I'll apply the patch below. > On 2014/4/4 0:09, Bjorn Helgaas wrote: > > Coverity complains that "smpss" is used uninitialized in > > drivers/pci/probe.c in pcie_bus_configure_settings() when calling > > pcie_bus_configure_set(): > > > > 1642 pcie_bus_configure_set(bus->self, &smpss); > > 1643 pci_walk_bus(bus, pcie_bus_configure_set, &smpss); > > > > "smpss" may be uninitialized, and pcie_bus_configure_set() > > dereferences the pointer it receives. > > > > This is CID 146454. > > > > Bjorn PCI: Fix use of uninitialized MPS value From: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> If "pcie_bus_config == PCIE_BUS_PERFORMANCE", we don't initialize "smpss", so we pass a pointer to garbage into pcie_bus_configure_set(), where we compute "mps" based on the garbage. We then pass the garbage "mps" to pcie_write_mps(), which ignores it in the PCIE_BUS_PERFORMANCE case. Coverity isn't smart enough to deduce that we ignore the garbage (it's a lot to expect from a human, too), so initialize "smpss" to a safe value in all cases. Found by Coverity (CID 146454). Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx> --- drivers/pci/probe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index fe89a982a3da..490031fd2108 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -1617,7 +1617,7 @@ static int pcie_bus_configure_set(struct pci_dev *dev, void *data) */ void pcie_bus_configure_settings(struct pci_bus *bus) { - u8 smpss; + u8 smpss = 0; if (!bus->self) return; -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
